Ensure queues are created with auto-delete and exclusive set to false

Since rabbitmq/rabbitmq-erlang-client#16, the `durable` parameter is
honored (instead of being forced to true). So AMQP 1.0 queues are
created as non-durable.

In our Erlang AMQP client, this means the queue is created with
auto-delete and exclusive set to true by default. We must explicitely
set those to false.

The testsuite is expanded to check that AMQP 0-9-1 queues created
out-of-band can be properly used from AMQP 1.0, no matter their
parameters.

Fixes #22.

Author: dumbbell

deps/rabbitmq_amqp1_0/src/rabbit_amqp1_0_incoming_link.erl

@@ -193,6 +193,8 @@ ensure_target(Target = #'v1_0.target'{address       = Address,
                                       timeout       = _Timeout},
               Link = #incoming_link{ route_state = RouteState }, DCh) ->
     DeclareParams = [{durable, rabbit_amqp1_0_link_util:durable(Durable)},
+                     {exclusive, false},
+                     {auto_delete, false},
                      {check_exchange, true},
                      {nowait, false}],
     case Dynamic of

deps/rabbitmq_amqp1_0/src/rabbit_amqp1_0_outgoing_link.erl

@@ -157,6 +157,8 @@ ensure_source(Source = #'v1_0.source'{address       = Address,
                                       timeout       = _Timeout},
               Link = #outgoing_link{ route_state = RouteState }, DCh) ->
     DeclareParams = [{durable, rabbit_amqp1_0_link_util:durable(Durable)},
+                     {exclusive, false},
+                     {auto_delete, false},
                      {check_exchange, true},
                      {nowait, false}],
     case Dynamic of

deps/rabbitmq_amqp1_0/test/swiftmq/test/com/rabbitmq/amqp1_0/tests/swiftmq/SwiftMQTests.java

@@ -226,10 +226,28 @@ public void testRouting() throws Exception {
         route("/exchange/amq.direct/",     "/exchange/amq.direct",  "",        true);
         route("/exchange/amq.direct/a",    "/exchange/amq.direct",  "a",       true);
 
+        /* The following three tests rely on the queue "test" created by
+         * previous tests in this function. */
         route("/amq/queue/test",           QUEUE,                   "",        true);
         route(QUEUE,                       "/amq/queue/test",       "",        true);
         route("/amq/queue/test",           "/amq/queue/test",       "",        true);
 
+        /* The following tests verify that a queue created out-of-band in AMQP
+         * is reachable from the AMQP 1.0 world. */
+        ConnectionFactory factory = new ConnectionFactory();
+        com.rabbitmq.client.Connection connection = factory.newConnection();
+        Channel channel = connection.createChannel();
+        channel.queueDeclare("transient_q", false, false, false, null);
+        route("/amq/queue/transient_q",    "/amq/queue/transient_q", "",       true);
+        channel.queueDelete("transient_q");
+        channel.queueDeclare("durable_q", true, false, false, null);
+        route("/amq/queue/durable_q",      "/amq/queue/durable_q",  "",        true);
+        channel.queueDelete("durable_q");
+        channel.queueDeclare("autodel_q", false, false, true, null);
+        route("/amq/queue/autodel_q",      "/amq/queue/autodel_q",  "",        true);
+        channel.queueDelete("autodel_q");
+        connection.close();
+
         route("/exchange/amq.direct/b",    "/exchange/amq.direct",  "a",       false);
         route(QUEUE,                       "/exchange/amq.fanout",  "",        false);
         route(QUEUE,                       "/exchange/amq.headers", "",        false);
@@ -243,7 +261,7 @@ public void testRoutingInvalidRoutes() throws Exception {
         channel.queueDeclare("transient", false, false, false, null);
         connection.close();
 
-        for (String dest : Arrays.asList("/exchange/missing", "/queue/transient", "/fruit/orange")) {
+        for (String dest : Arrays.asList("/exchange/missing", "/fruit/orange")) {
             routeInvalidSource(dest);
             routeInvalidTarget(dest);
         }