Peer discovery core logic rewrite follow-up improvements #10073
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow up to #9797. Submitted by: @lukebakken
[Why] They both can be useful to diagnose before debug messages are enabled. Also, the second message tells to enable debug messages to get more details, but it was logged at the debug level :-) Follow up to #9797. Submitted by: @lukebakken
[Why] We start a temporary hidden node, then ask it to execute some code, then stop it. But if there is an execution in between, we leave the temporary hidden node running. Likewise when we mess with the group leader: if the function executed after overriding the group leader temporarily raises an exception, the group leader becomes permanent and we may miss log messages. [How] We simply use a try/after block to ensure the temporary things are reverted at the end, regardless of the success or failure. Follow up to #9797. Submitted by: @lukebakken
… leader ... to exit. [How] It should never be stuck obviously™. But in case planets are not aligned, we wait for its exit with a timeout. If it stays around, this is not the end of the world. Follow up to #9797. Submitted by: @lukebakken
dumbbell
changed the title
michaelklishin
approved these changes
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a collection of improvements from @lukebakken. He submitted a review to #9797 seconds after I merged the branch. This pull request should address all his feedback.
Thank you @lukebakken!