Skip to content

Replaced true | false by boolean() (backport #10225) #10228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 23, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions deps/amqp10_common/src/amqp10_binary_generator.erl
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,8 @@

-type amqp10_prim() ::
null |
true |
false |
{boolean, true | false} |
boolean() |
{boolean, boolean()} |
{ubyte, byte()} |
{ushort, non_neg_integer()} |
{uint, non_neg_integer()} |
Expand Down
2 changes: 1 addition & 1 deletion deps/amqp_client/src/amqp_channel.erl
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@
waiting_set = gb_trees:empty(),
only_acks_received = true,

%% true | false, only relevant in the direct
%% boolean(), only relevant in the direct
%% client case.
%% when true, consumers will manually notify
%% queue pids using rabbit_amqqueue_common:notify_sent/2
Expand Down
2 changes: 1 addition & 1 deletion deps/rabbit/src/rabbit_amqqueue_process.erl
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@
mirroring_policy_version = 0,
%% running | flow | idle
status,
%% true | false
%% boolean()
single_active_consumer_on
}).

Expand Down
2 changes: 1 addition & 1 deletion deps/rabbitmq_aws/src/rabbitmq_aws_config.erl
Original file line number Diff line number Diff line change
Expand Up @@ -290,7 +290,7 @@ ini_file_data(Path) ->
ini_file_data(Path, filelib:is_file(Path)).


-spec ini_file_data(Path :: string(), FileExists :: true | false)
-spec ini_file_data(Path :: string(), FileExists :: boolean())
-> list() | {error, atom()}.
%% @doc Return the parsed ini file for the specified path.
%% @end
Expand Down
2 changes: 1 addition & 1 deletion deps/rabbitmq_management/src/rabbit_mgmt_util.erl
Original file line number Diff line number Diff line change
Expand Up @@ -523,7 +523,7 @@ pagination_params(ReqData) ->
[PageNum, PageSize])})
end.

-spec maybe_reverse([any()], string() | true | false) -> [any()].
-spec maybe_reverse([any()], string() | boolean()) -> [any()].
maybe_reverse([], _) ->
[];
maybe_reverse(RangeList, true) when is_list(RangeList) ->
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -262,11 +262,11 @@ maybe_cleanup(State, UnreachableNodes) ->
%% @doc Iterate over the list of partitioned nodes, either logging the
%% node that would be removed or actually removing it.
%% @spec maybe_remove_nodes(PartitionedNodes :: [node()],
%% WarnOnly :: true | false) -> ok
%% WarnOnly :: boolean()) -> ok
%% @end
%%--------------------------------------------------------------------
-spec maybe_remove_nodes(PartitionedNodes :: [node()],
WarnOnly :: true | false) -> ok.
WarnOnly :: boolean()) -> ok.
maybe_remove_nodes([], _) -> ok;
maybe_remove_nodes([Node | Nodes], true) ->
?LOG_WARNING(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -246,7 +246,7 @@ node_name_parse(Value) ->
%% result of the IPv4 check is processed.
%% @end
%%--------------------------------------------------------------------
-spec node_name_parse(IsIPv4 :: true | false, Value :: string())
-spec node_name_parse(IsIPv4 :: boolean(), Value :: string())
-> string().
node_name_parse(true, Value) -> Value;
node_name_parse(false, Value) ->
Expand Down