Skip to content

Resolve CLI elixirc warnings (backport #10459) #10462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Feb 1, 2024

This is an automatic backport of pull request #10459 done by Mergify.
Cherry-pick of c285651 has failed:

On branch mergify/bp/v3.12.x/pr-10459
Your branch is ahead of 'origin/v3.12.x' by 1 commit.
  (use "git push" to publish your local commits)

You are currently cherry-picking commit c285651636.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   deps/rabbitmq_cli/lib/rabbitmq/cli/core/command_modules.ex
	modified:   deps/rabbitmq_cli/lib/rabbitmq/cli/ctl/commands/add_user_command.ex
	modified:   deps/rabbitmq_cli/lib/rabbitmq/cli/ctl/commands/update_cluster_nodes_command.ex
	modified:   deps/rabbitmq_cli/lib/rabbitmq/cli/diagnostics/commands/list_policies_that_match.ex
	modified:   deps/rabbitmq_cli/lib/rabbitmq/cli/diagnostics/commands/remote_shell_command.ex

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	deleted by us:   deps/rabbitmq_cli/lib/rabbitmq/cli/ctl/commands/force_standalone_khepri_boot.ex
	both modified:   deps/rabbitmq_cli/lib/rabbitmq/cli/ctl/commands/forget_cluster_node_command.ex
	both modified:   deps/rabbitmq_cli/lib/rabbitmq/cli/ctl/commands/join_cluster_command.ex
	both modified:   deps/rabbitmq_cli/lib/rabbitmq/cli/ctl/commands/rename_cluster_node_command.ex
	deleted by us:   deps/rabbitmq_cli/lib/rabbitmq/cli/diagnostics/commands/check_if_any_deprecated_features_are_used_command.ex
	deleted by us:   deps/rabbitmq_cli/lib/rabbitmq/cli/diagnostics/commands/metadata_store_status_command.ex
	deleted by us:   deps/rabbitmq_cli/lib/rabbitmq/cli/streams/commands/coordinator_status_command.ex

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

This test should fail when `mix compile --warnings-as-errors` gives
any warnings.

(cherry picked from commit cc12d73)
* Remove unused aliases/imports
* Remove or underscore unused bindings
* Fix variables that should be atoms (`unavailable` -> `:unavailable`)

Also, `Logger.warn/1` has been replaced by `Logger.warning/1`. It should
be safe to just replace the call with `Logger.warning/1` since it's
been in the standard library since Elixir 1.11.

(cherry picked from commit c285651)

# Conflicts:
#	deps/rabbitmq_cli/lib/rabbitmq/cli/ctl/commands/force_standalone_khepri_boot.ex
#	deps/rabbitmq_cli/lib/rabbitmq/cli/ctl/commands/forget_cluster_node_command.ex
#	deps/rabbitmq_cli/lib/rabbitmq/cli/ctl/commands/join_cluster_command.ex
#	deps/rabbitmq_cli/lib/rabbitmq/cli/ctl/commands/rename_cluster_node_command.ex
#	deps/rabbitmq_cli/lib/rabbitmq/cli/diagnostics/commands/check_if_any_deprecated_features_are_used_command.ex
#	deps/rabbitmq_cli/lib/rabbitmq/cli/diagnostics/commands/metadata_store_status_command.ex
#	deps/rabbitmq_cli/lib/rabbitmq/cli/streams/commands/coordinator_status_command.ex
@mergify mergify bot added the conflicts label Feb 1, 2024
@mergify mergify bot added the bazel label Feb 1, 2024
@michaelklishin michaelklishin deleted the mergify/bp/v3.12.x/pr-10459 branch February 2, 2024 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants