Skip to content

Provide some defaults for embedding #1134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 22, 2017

Conversation

binarin
Copy link
Contributor

@binarin binarin commented Mar 3, 2017

Sorry, erroneously submitted to master the first time.

This commit provides defaults for some paths (similar to the thing the
mnesia does with its dir parameter) that will allow us to start
broker in embedded mode without any additional configuration. The
minimal test-case is to issue the following commands from
rabbitmq-server checkout:

make shell "SHELL_OPTS=-sname embed-friendly@localhost"
> rabbit:start().

This commit provides defaults for some paths (similar to the thing the
mnesia does with its `dir` parameter) that will allow us to start
broker in embedded mode without any additional configuration. The
minimal test-case is to issue the following commands from
`rabbitmq-server` checkout:

    make shell "SHELL_OPTS=-sname embed-friendly@localhost"
    > rabbit:start().
Copy link
Collaborator

@michaelklishin michaelklishin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This breaks clustering_management_SUITE (can be executed separately with gmake ct-clustering_management).

Use a more descriptive variable name, which explains why this can't be
actually squashed into a single call to rabbit_mnesia:dir/0.
@binarin
Copy link
Contributor Author

binarin commented Mar 17, 2017

Fixed

@michaelklishin michaelklishin merged commit f6da25c into rabbitmq:stable Mar 22, 2017
binarin pushed a commit to binarin/rabbitmq-server that referenced this pull request May 5, 2017
binarin pushed a commit to binarin/rabbitmq-server that referenced this pull request May 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants