Revert "rabbit_feature_flags: Retry after erpc:call() fails with noconnection"
#11507
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Additional observations:
|
dumbbell
force-pushed
the
revert-retry-after-noconnection-in-feature-flags-subsystem
branch
from
ec41f06 to
61346ee
Compare
…onnection`" This reverts commit 8749c60. [Why] The patch was supposed to solve an issue that we didn't understand and that was likely a network/DNS problem outside of RabbitMQ. We know it didn't solve that issue because it was reported again 6 months after the initial pull request (#8411). What we are sure however is that it increased the testing of RabbitMQ significantly because the code loops for 10+ minutes if the remote node is not running. The retry in the Feature flags subsystem was not the right place either. The `noconnection` error is visible there because it runs earlier during RabbitMQ startup. But retrying there won't solve a network issue magically. There are two ways to create a cluster: 1. peer discovery and this subsystem takes care of retries if necessary and appropriate 2. manually using the CLI, in which case the user is responsible for starting RabbitMQ nodes and clustering them Let's revert it until the root cause is really understood.
dumbbell
force-pushed
the
revert-retry-after-noconnection-in-feature-flags-subsystem
branch
from
61346ee to
d0c13b4
Compare
kjnilsson
approved these changes
Jun 20, 2024
dumbbell
deleted the
revert-retry-after-noconnection-in-feature-flags-subsystem
branch
dumbbell
added a commit
that referenced
this pull request
Jul 10, 2024
Revert "rabbit_feature_flags: Retry after erpc:call() fails with `noconnection`" (backport #11507)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 8749c60.
Why
The patch was supposed to solve an issue that we didn't understand and that was likely a network/DNS problem outside of RabbitMQ. We know it didn't solve that issue because it was reported again 6 months after the initial pull request (#8411).
What we are sure however is that it increased the testing of RabbitMQ significantly because the code loops for 10+ minutes if the remote node is not running.
The retry in the Feature flags subsystem was not the right place either. The
noconnectionerror is visible there because it runs earlier during RabbitMQ startup. But retrying there won't solve a network issue magically.There are two ways to create a cluster:
Let's revert it until the root cause is really understood.