Turn off mixed version tests against Khepri (backport #11663) #11669
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
Khepri is experimental and not guaranteed to be upgradable. We should re-enable mixed version testing as Khepri stabilizes but for now we should turn it off. This saves some CI time and avoids some failures that will be introduced when we upgrade Khepri to v0.14.0. (cherry picked from commit e08310a)
Khepri is not yet compatible with mixed-version testing and this suite only tests clustering when Khepri is the metadata store in at least some of the nodes. (cherry picked from commit bda1f7c)
…esia This suite is only meant to run with Khepri as the metadata store. Instead of setting this explicitly we can look at the configured metadata store and conditionally skip the entire suite. This prevents these tests from running twice in CI. (cherry picked from commit ecb7575)
(cherry picked from commit 0a4e5a9)
(cherry picked from commit da83358)
(cherry picked from commit 56bbf37)
This comment was marked as resolved.
This comment was marked as resolved.
Without buildbuddy for parallelization and with the change in the parent commit to reduce the number of cases, the suite now runs fast enough that sharding is counterproductive. (cherry picked from commit 95279a3) # Conflicts: # deps/rabbitmq_consistent_hash_exchange/BUILD.bazel
the-mikedavis
force-pushed
the
mergify/bp/v3.13.x/pr-11663
branch
from
208086c to
29d1a3f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Khepri v0.14.0 creates problems for mixed-version tests: the new machine version causes commands and queries to fail on the nodes running the old version. We should separately fix these issues and eventually re-enable mixed version tests with Khepri as the feature stabilizes.
This is an automatic backport of pull request #11663 done by Mergify.