Use 'try'/'catch' rather than 'ets:whereis/1' for Khepri projections #11700
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`ets:whereis/1` adds some overhead - it's two ETS calls rather than one when `ets:whereis/1` returns a table identifier. It's also not atomic: the table could disappear between `ets:whereis/1` calls and the call to read data from a projection. We replace all `ets:whereis/1` calls on projection tables with `try`/`catch` and return default values when we catch the `badarg` `error` which ETS emits when passed a non-existing table name. One special case though is `ets:info/2` which returns `undefined` when passed a non-existing table names. That block is refactored to use a `case` instead.
|
Good point about the overhead @dumbbell I'm not so worried about tables disappearing but who knows! |
michaelklishin
approved these changes
Jul 12, 2024
the-mikedavis
added a commit
that referenced
this pull request
Jul 12, 2024
Use 'try'/'catch' rather than 'ets:whereis/1' for Khepri projections (backport #11700)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #11667 (comment)
ets:whereis/1adds some overhead - it's two ETS calls rather than one whenets:whereis/1returns a table identifier. It's also not atomic: the table could disappear betweenets:whereis/1calls and the call to read data from a projection. We replace allets:whereis/1calls on projection tables withtry/catchand return default values when we catch thebadargerrorwhich ETS emits when passed a non-existing table name.One special case though is
ets:info/2which returnsundefinedwhen passed a non-existing table names. That block is refactored to use acaseinstead.