Skip to content

CMQ cleanup #11716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 15, 2024
Merged

CMQ cleanup #11716

merged 5 commits into from
Jul 15, 2024

Conversation

mkuratczyk
Copy link
Contributor

More CMQ leftovers

@michaelklishin michaelklishin added this to the 4.0.0 milestone Jul 15, 2024
mkuratczyk and others added 5 commits July 15, 2024 12:38
@mkuratczyk @michaelklishin
Remove sync_queue and cancel_sync_queue from man page
6b13771
@mkuratczyk @michaelklishin
check_if_node_is_mirror_sync_critical is no-op
e1b649c 
Make `check_if_node_is_mirror_sync_critical` a no-op
with a deprecation warning. Since this command is commonly used
as part of the node shutdown process (eg. by Cluster Operator),
making it a no-op instead of removing completly will make the
transition to 4.0 easier for users.
@mkuratczyk @michaelklishin
Remove HA policy example from OpenStack script
9debca2
@michaelklishin
Fix two warnings in a deprecated CMQ-related CLI command
8de26fb
@michaelklishin
Squash two more deprecated CMQ-related CLI command warnings
5346339
@michaelklishin
Copy link
Collaborator

The maintenance_SUITE-mixed failure might have been fixed recently:


2024-07-15 15:46:44.593438+00:00 [error] <0.1557.0> ** Generic server <0.1557.0> terminating
2024-07-15 15:46:44.593438+00:00 [error] <0.1557.0> ** Last message in was check_vhost
2024-07-15 15:46:44.593438+00:00 [error] <0.1557.0> ** When Server state == <<"/">>
2024-07-15 15:46:44.593438+00:00 [error] <0.1557.0> ** Reason for termination ==
2024-07-15 15:46:44.593438+00:00 [error] <0.1557.0> ** {badarg,[{ets,member,
2024-07-15 15:46:44.593438+00:00 [error] <0.1557.0>                  [rabbit_khepri_vhost,<<"/">>],
2024-07-15 15:46:44.593438+00:00 [error] <0.1557.0>                  [{error_info,#{cause => id,module => erl_stdlib_errors}}]},
2024-07-15 15:46:44.593438+00:00 [error] <0.1557.0>             {rabbit_db_vhost,exists_in_khepri,1,
2024-07-15 15:46:44.593438+00:00 [error] <0.1557.0>                              [{file,"rabbit_db_vhost.erl"},{line,245}]},
2024-07-15 15:46:44.593438+00:00 [error] <0.1557.0>             {rabbit_vhost_process,handle_info,2,
2024-07-15 15:46:44.593438+00:00 [error] <0.1557.0>                                   [{file,"rabbit_vhost_process.erl"},
2024-07-15 15:46:44.593438+00:00 [error] <0.1557.0>                                    {line,63}]},
2024-07-15 15:46:44.593438+00:00 [error] <0.1557.0>             {gen_server2,handle_msg,2,[{file,"gen_server2.erl"},{line,1056}]},
2024-07-15 15:46:44.593438+00:00 [error] <0.1557.0>             {proc_lib,init_p_do_apply,3,[{file,"proc_lib.erl"},{line,241}]}]}
2024-07-15 15:46:44.593438+00:00 [error] <0.1557.0> 
2024-07-15 15:46:44.593761+00:00 [error] <0.1557.0>   crasher:
2024-07-15 15:46:44.593761+00:00 [error] <0.1557.0>     initial call: rabbit_vhost_process:init/1
2024-07-15 15:46:44.593761+00:00 [error] <0.1557.0>     pid: <0.1557.0>
2024-07-15 15:46:44.593761+00:00 [error] <0.1557.0>     registered_name: []
2024-07-15 15:46:44.593761+00:00 [error] <0.1557.0>     exception exit: {badarg,
2024-07-15 15:46:44.593761+00:00 [error] <0.1557.0>                         [{ets,member,
2024-07-15 15:46:44.593761+00:00 [error] <0.1557.0>                              [rabbit_khepri_vhost,<<"/">>],
2024-07-15 15:46:44.593761+00:00 [error] <0.1557.0>                              [{error_info,
2024-07-15 15:46:44.593761+00:00 [error] <0.1557.0>                                   #{cause => id,
2024-07-15 15:46:44.593761+00:00 [error] <0.1557.0>                                     module => erl_stdlib_errors}}]},
2024-07-15 15:46:44.593761+00:00 [error] <0.1557.0>                          {rabbit_db_vhost,exists_in_khepri,1,
2024-07-15 15:46:44.593761+00:00 [error] <0.1557.0>                              [{file,"rabbit_db_vhost.erl"},{line,245}]},
2024-07-15 15:46:44.593761+00:00 [error] <0.1557.0>                          {rabbit_vhost_process,handle_info,2,
2024-07-15 15:46:44.593761+00:00 [error] <0.1557.0>                              [{file,"rabbit_vhost_process.erl"},{line,63}]},
2024-07-15 15:46:44.593761+00:00 [error] <0.1557.0>                          {gen_server2,handle_msg,2,
2024-07-15 15:46:44.593761+00:00 [error] <0.1557.0>                              [{file,"gen_server2.erl"},{line,1056}]},
2024-07-15 15:46:44.593761+00:00 [error] <0.1557.0>                          {proc_lib,init_p_do_apply,3,
2024-07-15 15:46:44.593761+00:00 [error] <0.1557.0>                              [{file,"proc_lib.erl"},{line,241}]}]}
2024-07-15 15:46:44.593761+00:00 [error] <0.1557.0>       in function  gen_server2:terminate/3 (gen_server2.erl, line 1172)
2024-07-15 15:46:44.593761+00:00 [error] <0.1557.0>     ancestors: [<0.1555.0>,rabbit_vhost_sup_sup,rabbit_sup,<0.1284.0>]

@michaelklishin michaelklishin merged commit ff5a324 into main Jul 15, 2024
190 of 191 checks passed
@michaelklishin michaelklishin deleted the cmq-cleanup branch July 15, 2024 17:39
@mergify mergify bot mentioned this pull request Jul 15, 2024
Merged
michaelklishin added a commit that referenced this pull request Jul 15, 2024
@michaelklishin
Merge pull request #11718 from rabbitmq/mergify/bp/v4.0.x/pr-11716
dad074e 
CMQ cleanup (backport #11716)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@mkuratczyk @michaelklishin