Skip to content

OAuth 2, breaking change: upgrade oidc-client-ts library to a new major (backport #11423) #11717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 15, 2024
Merged

OAuth 2, breaking change: upgrade oidc-client-ts library to a new major (backport #11423) #11717

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9b1d604
Replace oidc-client-ts dependencies
MarcialRosales Jun 10, 2024
6e224d2
Do not test against UAA
MarcialRosales Jun 12, 2024
bbf9c14
Merge changes from main
MarcialRosales Jun 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions deps/rabbitmq_management/app.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -312,8 +312,8 @@ def all_srcs(name = "all_srcs"):
"priv/www/js/oidc-oauth/helper.js",
"priv/www/js/oidc-oauth/login-callback.html",
"priv/www/js/oidc-oauth/logout-callback.html",
"priv/www/js/oidc-oauth/oidc-client-ts.js",
"priv/www/js/oidc-oauth/oidc-client-ts.js.map",
"priv/www/js/oidc-oauth/oidc-client-ts.3.0.1.min.js",
"priv/www/js/oidc-oauth/oidc-client-ts.3.0.1.min.js.map",
"priv/www/js/prefs.js",
"priv/www/js/sammy-0.7.6.js",
"priv/www/js/sammy-0.7.6.min.js",
Expand Down
2 changes: 1 addition & 1 deletion deps/rabbitmq_management/priv/www/js/oidc-oauth/helper.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import {oidc} from './oidc-client-ts.js';
import {oidc} from './oidc-client-ts.3.0.1.min.js';

var mgr;
var _management_logger;
Expand Down
3 changes: 3 additions & 0 deletions deps/rabbitmq_management/priv/www/js/oidc-oauth/oidc-client-ts.3.0.1.min.js
View file
Open in desktop

Large diffs are not rendered by default.

7 changes: 7 additions & 0 deletions deps/rabbitmq_management/priv/www/js/oidc-oauth/oidc-client-ts.3.0.1.min.js.map
View file
Open in desktop

Large diffs are not rendered by default.

7 changes: 0 additions & 7 deletions deps/rabbitmq_management/priv/www/js/oidc-oauth/oidc-client-ts.js.map
View file
Open in desktop

This file was deleted.

2 changes: 0 additions & 2 deletions deps/rabbitmq_management/selenium/full-suite-management-ui
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,8 @@ authnz-mgt/oauth-idp-initiated-with-uaa-via-proxy.sh
authnz-mgt/oauth-idp-initiated-with-uaa.sh
authnz-mgt/oauth-with-keycloak.sh
authnz-mgt/oauth-with-keycloak-with-verify-none.sh
authnz-mgt/oauth-with-uaa-and-mgt-prefix.sh
authnz-mgt/oauth-with-uaa-down-but-with-basic-auth.sh
authnz-mgt/oauth-with-uaa-down.sh
authnz-mgt/oauth-with-uaa.sh
mgt/vhosts.sh
mgt/definitions.sh
mgt/exchanges.sh
Expand Down
2 changes: 1 addition & 1 deletion deps/rabbitmq_management/selenium/short-suite-management-ui
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
authnz-mgt/basic-auth.sh
authnz-mgt/oauth-with-uaa.sh
authnz-mgt/oauth-with-keycloak.sh
mgt/vhosts.sh
mgt/exchanges.sh
mgt/limits.sh
1 change: 1 addition & 0 deletions deps/rabbitmq_management/selenium/test/oauth/with-sp-initiated/unauthorized.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ describe('An user without management tag', function () {
})

it('should get redirected to home page again without error message', async function(){
await homePage.isLoaded()
const visible = await homePage.isWarningVisible()
assert.ok(!visible)
})
Expand Down
Loading