rabbit_khepri: Retry register_projections during boot #11741
Merged
+20
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gives some time to form a majority during the boot process, allowing nodes to boot more easily
| rabbit_log:info("Waiting for Khepri projections for ~tp ms, ~tp retries left", | ||
| [Timeout, Retries - 1]), | ||
| try | ||
| register_projections() |
There was a problem hiding this comment.
This would retry registering all projections again if it fails. I think that's probably ok since I expect the first projection would be the only one to time out but we could make this a little more clever and fold over the list of projections to register and the retry number. Feel free to ignore though, it seems very unlikely to be hit in practice
the-mikedavis
approved these changes
Jul 17, 2024
dcorbacho
force-pushed
the
retry-register-projections-during-boot
branch
from
ad04139 to
cdff2ae
Compare
michaelklishin
added a commit
that referenced
this pull request
Jul 25, 2024
rabbit_khepri: Retry register_projections during boot (backport #11741)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gives some time to form a majority during the boot process, allowing nodes to boot more easily.
See discussion #11685 (comment)