QQ: use a dedicated function for queue recovery after Ra system restart. #11809
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansd
reviewed
Jul 24, 2024
kjnilsson
force-pushed
the
qq-system-recovery
branch
2 times, most recently
from
bdf1079 to
df22e17
Compare
Previously we used the `registered` approach where all Ra servers that have a registered name would be recovered. This could have unintended side effects for queues that e.g. were deleted when not all members of a quorum queueu were running when the queue was deleted. In this case the Ra system would have recovered the members that were not deleted which is not ideal as a dangling member would just sit and loop in pre vote state and a future declaration of the queue may partially fail. Instead we rely on the meta data store for the truth about which members should be restarted after a ra system restart.
kjnilsson
force-pushed
the
qq-system-recovery
branch
from
df22e17 to
4863bc3
Compare
michaelklishin
approved these changes
Jul 24, 2024
ansd
approved these changes
Jul 24, 2024
michaelklishin
added a commit
that referenced
this pull request
Jul 24, 2024
QQ: use a dedicated function for queue recovery after Ra system restart. (backport #11809)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we used the
registeredapproach where all Ra servers that have a registered name would be recovered. This could have unintended side effects for queues that e.g. were deleted when not all members of a quorum queueu were running when the queue was deleted. In this case the Ra system would have recovered the members that were not deleted which is not ideal as a dangling member would just sit and loop in pre vote state and a future declaration of the queue may partially fail.Instead we rely on the meta data store for the truth about which members should be restarted after a ra system restart.