Close MQTT connection with delay when authentication fails (backport #11900) (backport #11904) #11906
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
For consistency with other protocols (to protect from potential DoS attacks). Wrong credentials and virtual host access errors trigger the delay. References #11831 We keep the delay low when running tests. Otherwise, ``` make -C deps/rabbitmq_mqtt ct-auth ``` would run 3 minutes longer (with a SILENT_CLOSE_DELAY of 3 seconds). (cherry picked from commit 80ff6d0) (cherry picked from commit 9e84378)
michaelklishin
force-pushed
the
mergify/bp/v3.13.x/pr-11904
branch
from
93b90c7 to
58fbe75
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For consistency with other protocols (to protect from potential DoS attacks). Wrong credentials and virtual host access errors trigger the delay.
References #11831
We keep the delay low when running tests. Otherwise,
would run 3 minutes longer (with a SILENT_CLOSE_DELAY of 3 seconds).
This is an automatic backport of pull request #11900 done by Mergify.
This is an automatic backport of pull request #11904 done by Mergify.