Reduce Khepri test flakes #11917
Merged
Reduce Khepri test flakes #11917
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test case rabbit_mqtt_qos0_queue_kill_node flaked because after an MQTT client subscribes on node 0, RabbitMQ returns success and replicated the new binding to node 0 and node 1, but not yet to node 2. Another MQTT client then publishes on node 2 without the binding being present yet on node 2, and the message therefore isn't routed. This commit attempts to eliminate this flake. It adds a function to rabbit_ct_broker_helpers which waits until a given node has caught up with the leader node. We can reuse that function in future to eliminate more test flakes.
This was referenced Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test case rabbit_mqtt_qos0_queue_kill_node flaked because after an MQTT client subscribes on node 0, RabbitMQ returns success and replicated the new binding to node 0 and node 1, but not yet to node 2. Another MQTT client then publishes on node 2 without the binding being present yet on node 2, and the message therefore isn't routed.
This commit attempts to eliminate this flake.
It adds a function to rabbit_ct_broker_helpers which waits until a given node has caught up with the leader node.
We can reuse that function in future to eliminate more test flakes.