Don't return khepri status when khperi_db is disabled #12085
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When khepri_db feature flag is disabled, Khepri servers are running but are not clustered. In this case `rabbit_khepri:status/0` shows that all nodes are leaders, which is confusing and scary (even though actually harmless). Instead, we now just print that mnesia is in use.
michaelklishin
approved these changes
Aug 22, 2024
michaelklishin
added a commit
that referenced
this pull request
Aug 22, 2024
Don't return khepri status when khperi_db is disabled (backport #12085)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When khepri_db feature flag is disabled, Khepri servers are running but are not clustered. In this case
rabbit_khepri:status/0shows that all nodes are leaders, which is confusing and scary (even though actually harmless). Instead, we now just print that mnesia is in use.