Prevent exchange logging crash (backport #12104) #12105
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
Don't let the `log` callback of exchange_logging handler crash, because in case of a crash OTP logger removes the exchange_logger handler, which in turn deletes the log exchange and its bindings. It was seen several times in production that the log exchange suddenly disappears and without debug logging there is no trace of why. With this commit `erlang:display` will print the reason and stacktrace to stderr without using the logging infrastructure. (cherry picked from commit 34bcb91)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is #12100 by @gomoripeti submitted by me so that Actions can run with access to GCP Bazel cache.
This is an automatic backport of pull request #12104 done by Mergify.