Skip to content

Support unicode messages by exchange logging #12146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

gomoripeti
Copy link
Contributor

Proposed Changes

Before this commit formatting the amqp body would crash and the log message would not be published to the log exchange.

Before commit 34bcb91 it even crashed the whole exchange logging handler which caused the log exchange to be deleted.

This is the root cause (or at least one of them) why log exchange was seen deleted as described in #12100

A real world example logging unicode:

MQTT connection failed: access refused for user 'Aðª':user 'A𪛔' - invalid credentials

Kudos to @johanrhodin who found the bug with extraordinary intuition.

Types of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause an observable behavior change in existing systems)
  • Documentation improvements (corrections, new content, etc)
  • Cosmetic change (whitespace, formatting, etc)
  • Build system and/or CI

Checklist

Put an x in the boxes that apply.
You can also fill these out after creating the PR.
If you're unsure about any of them, don't hesitate to ask on the mailing list.
We're here to help!
This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING.md document
  • I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
  • I have added tests that prove my fix is effective or that my feature works
  • All tests pass locally with my changes
  • If relevant, I have added necessary documentation to https://github.com/rabbitmq/rabbitmq-website
  • If relevant, I have added this change to the first version(s) in release-notes that I expect to introduce it

Further Comments

Before this commit formatting the amqp body would crash and the log
message would not be published to the log exchange.

Before commit 34bcb91 it even crashed the whole exchange logging
handler which caused the log exchange to be deleted.
@michaelklishin michaelklishin self-assigned this Aug 28, 2024
@michaelklishin michaelklishin merged commit 4fbfd98 into rabbitmq:main Aug 29, 2024
323 of 326 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants