Skip to content

Improve documentation around new default for background garbage collection #1252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 7, 2017

Conversation

FabianPonce
Copy link
Contributor

2f3fb80 (v3.6.7) altered the default setting for background_gc_enabled to false, however, the default configuration files seem to imply that the default value for this is still set to true.

This pull request corrects the default configuration and makes a small change to background_gc.erl so that the defaults which are set in the Makefile are clearly communicated to anyone viewing the source code as well.

…ground_gc_enabled to false to match the behavior of the Makefile.
@@ -74,7 +74,7 @@ interval_gc(State = #state{last_interval = LastInterval}) ->
State#state{last_interval = Interval}.

gc() ->
Enabled = rabbit_misc:get_env(rabbit, background_gc_enabled, true),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rabbit.background_gc_enabled has an application-level default, so this should not break anything.

@michaelklishin
Copy link
Collaborator

@FabianPonce thank you. Can you please submit the same change against stable? (note: there won't be rabbitmq.example.conf in that branch).

Copy link
Collaborator

@lukebakken lukebakken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me.

@FabianPonce
Copy link
Contributor Author

See #1253 for PR against stable branch. Thanks for the quick review, guys!

@michaelklishin michaelklishin merged commit 2da358c into rabbitmq:master Jun 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants