Locking support in cluster formation #1258
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adapted from autocluster to avoid race conditions on startup rabbitmq-server#125 [#146871615]
| lock() -> | ||
| Backend = backend(), | ||
| rabbit_log:info("Will try to lock with peer discovery backend ~s", [Backend]), | ||
| case Backend:lock(node()) of |
There was a problem hiding this comment.
Should the backend indicate whether locking is supported, like we do for registration? Should lock/1 and unlock/1 be a part of https://github.com/rabbitmq/rabbitmq-common/blob/rabbitmq-server-1257/src/rabbit_peer_discovery_backend.erl?
There was a problem hiding this comment.
There was a missing PR: https://github.com/rabbitmq/rabbitmq-common/pull/204/files.
The lock/1 return value of unsupported is not very consistent with supports_registration/0 but
it's consistent with rabbitmq-autocluster :/. Arguably this is not a show stopper for #1258 and 3.7.0 release plans.
michaelklishin
approved these changes
Jun 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapted from
rabbitmq_autoclusterto avoid race conditions on startupPart of #1257