Skip to content

Make it possible to set some cluster metadata besides the name using tags #12659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 11, 2024

Conversation

SimonUnge
Copy link
Collaborator

@SimonUnge SimonUnge commented Nov 4, 2024

Proposed Changes

Implements #12552.
Closes #12552.

Types of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause an observable behavior change in existing systems)
  • Documentation improvements (corrections, new content, etc)
  • Cosmetic change (whitespace, formatting, etc)
  • Build system and/or CI

Checklist

Put an x in the boxes that apply.
You can also fill these out after creating the PR.
If you're unsure about any of them, don't hesitate to ask on the mailing list.
We're here to help!
This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING.md document
  • I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
  • I have added tests that prove my fix is effective or that my feature works
  • All tests pass locally with my changes
  • If relevant, I have added necessary documentation to https://github.com/rabbitmq/rabbitmq-website
  • If relevant, I have added this change to the first version(s) in release-notes that I expect to introduce it

Further Comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution
you did and what alternatives you considered, etc.

@SimonUnge SimonUnge force-pushed the su_aws/cluster_tag branch 4 times, most recently from f79ecd0 to d4e3744 Compare November 6, 2024 19:56
@SimonUnge SimonUnge marked this pull request as ready for review November 8, 2024 21:51
@SimonUnge SimonUnge changed the title WIP: cluster tags cluster tags Nov 8, 2024
@michaelklishin michaelklishin changed the title cluster tags Make it possible to set some metadata besides cluster name using tags Nov 10, 2024
@michaelklishin michaelklishin changed the title Make it possible to set some metadata besides cluster name using tags Make it possible to set some cluster metadata besides the name using tags Nov 10, 2024
@michaelklishin michaelklishin added this to the 4.1.0 milestone Nov 10, 2024
@michaelklishin michaelklishin merged commit f5801be into main Nov 11, 2024
273 checks passed
@michaelklishin michaelklishin deleted the su_aws/cluster_tag branch November 11, 2024 00:17
michaelklishin added a commit that referenced this pull request Nov 11, 2024
michaelklishin added a commit that referenced this pull request Nov 11, 2024
michaelklishin added a commit that referenced this pull request Nov 11, 2024
Make it possible to set some cluster metadata besides the name using tags (backport #12659)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Introduce a way to tag clusters (and, optionally, nodes)
2 participants