Do not show queues with deleted vhost. #1301
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When vhost does not exist for a queue, which reside on a stopped node, the queue will not be displayed in the 'list_queues' command output. When a node goes back up, queues without vhost will be deleted. [Fixes #1300] [#149292743]
lukebakken
reviewed
Jul 21, 2017
| {atomic, ok} = | ||
| mnesia:sync_transaction( | ||
| fun () -> | ||
| rabbit_log:error("Deleting ~p~n", [LocalQueuesWithoutVhost]), |
There was a problem hiding this comment.
Should this be info rather than error?
There was a problem hiding this comment.
I'd make it a warning and explain why it's being deleted.
There was a problem hiding this comment.
That was a debug message. Do you think it should stay?
michaelklishin
approved these changes
Jul 21, 2017
|
Doh, I hit Merge in the wrong tab. Sorry. |
|
We agreed to do a couple of small adjustments in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When vhost does not exist for a queue, which reside on
a stopped node, the queue will not be displayed in the 'list_queues'
command output.
When a node goes back up, queues without vhost will be deleted.
[Fixes #1300]
[#149292743]