Skip to content

Redirect to end_session_endpoint for idp_initiated logon when it is configured #13344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 28, 2025

Conversation

MarcialRosales
Copy link
Contributor

Proposed Changes

Addresses #12545

Types of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause an observable behavior change in existing systems)
  • Documentation improvements (corrections, new content, etc)
  • Cosmetic change (whitespace, formatting, etc)
  • Build system and/or CI

@MarcialRosales MarcialRosales self-assigned this Feb 14, 2025
@MarcialRosales MarcialRosales changed the title Redirect to end_session_endpoint for idp_initiated logon when end_session_endpoint is configured Redirect to end_session_endpoint for idp_initiated logon when it is configured Feb 14, 2025
@MarcialRosales MarcialRosales force-pushed the issue-12545 branch 4 times, most recently from 3425f50 to d7ab7d1 Compare February 24, 2025 16:24
@MarcialRosales MarcialRosales force-pushed the issue-12545 branch 2 times, most recently from 9da4684 to 8290235 Compare February 27, 2025 08:54
@MirahImage
Copy link
Member

Can this be backported to 4.0 as well?

@michaelklishin
Copy link
Collaborator

@MirahImage from the looks of it, all these changes are node-local so, I'd say, yes.

@MarcialRosales
Copy link
Contributor Author

Yes @MirahImage It can be merged back to 4.0.x. I will test the back-port given there seems to be a customer waiting for it.

@michaelklishin
Copy link
Collaborator

Rebased on top of main.

@michaelklishin
Copy link
Collaborator

Because of the rebase it must be backported manually.

@michaelklishin michaelklishin marked this pull request as ready for review March 28, 2025 00:25
@michaelklishin michaelklishin merged commit bde9868 into main Mar 28, 2025
275 checks passed
@michaelklishin michaelklishin deleted the issue-12545 branch March 28, 2025 00:32
@michaelklishin
Copy link
Collaborator

@MarcialRosales I had to revert this PR because the Selenium suite fails repeatedly with certain configurations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants