Do not GC channel-queue metrics on mirror migration #1341
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rabbitmq-server#1340 [#150442817]
lukebakken
approved these changes
Aug 23, 2017
There was a problem hiding this comment.
I reproduced the issue (saw negative stats numbers and dips in the graphs) using a 3-node local cluster with this policy. PerfTest connected to the node not hosting the mirrored queue:
$ ./deps/rabbit/scripts/rabbitmqctl -n rabbit3@shostakovich list_policies
Listing policies
/ gh-1340 queues .* {"ha-mode":"exactly","ha-params":2} 0
I then applied these changes, and the issue does not appear again.
|
Tested this locally and deployed into our long-running environment. So far looking promising, no negative stats in over 1 hour (we had a setup that reproduced it every 2 minutes — so, after every stats GC run — before). |
michaelklishin
approved these changes
Aug 23, 2017
kjnilsson
approved these changes
Aug 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1340