-
Notifications
You must be signed in to change notification settings - Fork 3.9k
Optionally allow separate configuration of auth_backends for all HTTP-based plugins (protocols, APIs) #13464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
aaron-seo
wants to merge
4
commits into
rabbitmq:main
from
aaron-seo:as/web-dispatch-auth-backend-config
Closed
Optionally allow separate configuration of auth_backends for all HTTP-based plugins (protocols, APIs) #13464
aaron-seo
wants to merge
4
commits into
rabbitmq:main
from
aaron-seo:as/web-dispatch-auth-backend-config
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fallback to the core auth_backends
deps/rabbitmq_web_dispatch/priv/schema/rabbitmq_web_dispatch.schema
Outdated
Show resolved
Hide resolved
@aaron-seo I'm afraid the fallback message is logged so often that it's beyond reasonable even at |
michaelklishin
added a commit
that referenced
this pull request
Mar 7, 2025
Doing so for every HTTP API request is excessive even at debug level.
michaelklishin
added a commit
that referenced
this pull request
Mar 7, 2025
Doing so for every HTTP API request is excessive even at debug level. (cherry picked from commit 830374c)
Accepted with a small logging-related change in #13465 |
michaelklishin
added a commit
that referenced
this pull request
Mar 12, 2025
Doing so for every HTTP API request is excessive even at debug level. (cherry picked from commit 830374c)
michaelklishin
added a commit
that referenced
this pull request
Mar 17, 2025
Doing so for every HTTP API request is excessive even at debug level. (cherry picked from commit 830374c)
ikavgo
pushed a commit
that referenced
this pull request
May 5, 2025
Doing so for every HTTP API request is excessive even at debug level. (cherry picked from commit 830374c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
As discussed here #13205, and on community Slack, this PR allows a separate configuration of auth_backends for web_dispatch_access_control. This configuration is optional and designed to fallback to the regular
auth_backends
config, if not-configured.Tested with the following configs (and retested with
http_dispatch
prefix)Config 1 (empty):
Mgmt UI Auth with
internal
works, debug logs present for "fallback"Config 2:
Mgmt UI Auth with
internal
works, AMQP Auth withinternal
works, no debug logs for "fallback"Config 3:
Mgmt UI Auth with
internal
does not work, AMQP Auth withinternal
does not work, debug logs present for "fallback".Config 4:
Mgmt UI Auth with
internal
does not work, AMQP Auth withinternal
works, no debug logs for "fallback"Please describe the big picture of your changes here to communicate to the RabbitMQ team why we should accept this pull request.
If it fixes a bug or resolves a feature request, be sure to link to that issue.
A pull request that doesn't explain why the change was made has a much lower chance of being accepted.
Types of Changes
What types of changes does your code introduce to this project?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply.You can also fill these out after creating the PR.
If you're unsure about any of them, don't hesitate to ask on the mailing list.
We're here to help!
This is simply a reminder of what we are going to look for before merging your code.
CONTRIBUTING.md
documentFurther Comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution
you did and what alternatives you considered, etc.