Minor improvement: Remove observer_cli from CLI escritps (backport #13485) #13503
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
observer_cli (and its dependency recon) was declared as a dependency of rabbitmq_cli and as a consequence included in all escritps. However the major part of observer_cli runs in the broker. The cli side only used
observer_cli:rpc_start/2
which is just an rpc call into the target node.By using common rpc call we can remove observer_cli and recon from the escripts. This can be considered a minor improvement based on the philosophy "simpler is better".
As an additional benefit auto-completing functions of the recon app now works in
rabbitmq-diagnostics remote_shell
.(eg.
recon:proc_c<TAB>
) This was my main motivation for this change.Types of Changes
What types of changes does your code introduce to this project?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply.You can also fill these out after creating the PR.
If you're unsure about any of them, don't hesitate to ask on the mailing list.
We're here to help!
This is simply a reminder of what we are going to look for before merging your code.
CONTRIBUTING.md
documentFurther Comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution
you did and what alternatives you considered, etc.
This is an automatic backport of pull request #13485 done by [Mergify](https://mergify.com).