Skip to content

Refine CI triggers for building OCI #13534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 17, 2025
Merged

Refine CI triggers for building OCI #13534

merged 2 commits into from
Mar 17, 2025

Conversation

Zerpet
Copy link
Member

@Zerpet Zerpet commented Mar 14, 2025

Proposed Changes

  • Trigger OCI builds only on code changes
  • Build OCI only on commits to main

Right now, we are building a dev OCI on any type of changes. For example, changes to Selenim tests would
trigger a build of the OCI. This doesn't make sense because changes to tests do not alter RabbitMQ functionality.
This PR changes the triggers so that CI builds the OCI when there are changes to RabbitMQ code or its dependencies.

Types of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause an observable behavior change in existing systems)
  • Documentation improvements (corrections, new content, etc)
  • Cosmetic change (whitespace, formatting, etc)
  • Build system and/or CI

Checklist

Put an x in the boxes that apply.
You can also fill these out after creating the PR.
If you're unsure about any of them, don't hesitate to ask on the mailing list.
We're here to help!
This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING.md document
  • I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
  • I have added tests that prove my fix is effective or that my feature works
  • All tests pass locally with my changes
  • If relevant, I have added necessary documentation to https://github.com/rabbitmq/rabbitmq-website
  • If relevant, I have added this change to the first version(s) in release-notes that I expect to introduce it

@Zerpet Zerpet requested a review from mkuratczyk March 14, 2025 17:15
@Zerpet Zerpet self-assigned this Mar 14, 2025
@Zerpet
Copy link
Member Author

Zerpet commented Mar 14, 2025

@mkuratczyk I changed the workflow to trigger only on commits to main. I'm not sure whether that's desirable, or you'd prefer to build OCI for WIP branches as well. I don't have a strong opinion.

@mkuratczyk
Copy link
Contributor

Comparing the behaviour/performance of WIP branches vs main is one of the main uses cases for me, so I'd rather have the images built on branches as well.

Zerpet added 2 commits March 17, 2025 10:53
Prior to this change, we built the OCI for almost any change. That
doesn't make sense. For example, when there were changes to CI, it
didn't make because RabbitMQ had not changed.

CI will now build dev OCI images when there are actual code changes, or
changes to rabbit dependencies.
@Zerpet Zerpet force-pushed the ci/refine-oci-triggers branch from 2a83443 to 8fc3ce9 Compare March 17, 2025 10:53
@Zerpet Zerpet marked this pull request as ready for review March 17, 2025 10:54
@Zerpet
Copy link
Member Author

Zerpet commented Mar 17, 2025

Dropped the commit that filters the branch only to main. Now commits that match the path filter in any branch will trigger the dev OCI build.

@Zerpet Zerpet merged commit 24a0f29 into main Mar 17, 2025
4 of 271 checks passed
@Zerpet Zerpet deleted the ci/refine-oci-triggers branch March 17, 2025 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants