Skip to content

Extend rabbit_amqqueue_SUITE and add amqqueue:make_internal/{1,2} type specs #13565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 19, 2025

Conversation

Ayanda-D
Copy link
Contributor

Proposed Changes

Thank you for this #13525 - I just noticed something small missing: test (for owner=undefined) and some type specs.

Types of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause an observable behavior change in existing systems)
  • Documentation improvements (corrections, new content, etc)
  • Cosmetic change (whitespace, formatting, etc)
  • Build system and/or CI

Checklist

Put an x in the boxes that apply.
You can also fill these out after creating the PR.
If you're unsure about any of them, don't hesitate to ask on the mailing list.
We're here to help!
This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING.md document
  • I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
  • I have added tests that prove my fix is effective or that my feature works
  • All tests pass locally with my changes
  • If relevant, I have added necessary documentation to https://github.com/rabbitmq/rabbitmq-website
  • If relevant, I have added this change to the first version(s) in release-notes that I expect to introduce it

Further Comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution
you did and what alternatives you considered, etc.

…/1 and add amqqueue:make_internal/{1,2} type specs
@Ayanda-D Ayanda-D changed the title Extend rabbit_amqqueue_SUITE add amqqueue:make_internal/{1,2} type specs Extend rabbit_amqqueue_SUITE and add amqqueue:make_internal/{1,2} type specs Mar 18, 2025
@michaelklishin michaelklishin merged commit e93afc5 into rabbitmq:main Mar 19, 2025
269 of 271 checks passed
@michaelklishin michaelklishin added this to the 4.1.0 milestone Mar 19, 2025
@michaelklishin
Copy link
Collaborator

Thank you for contributing to RabbitMQ.

michaelklishin added a commit that referenced this pull request Mar 19, 2025
Extend rabbit_amqqueue_SUITE and add amqqueue:make_internal/{1,2} type specs (backport #13565)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants