Skip to content

Remove redundant rabbit_queue_type APIs #13603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 25, 2025

Conversation

kjnilsson
Copy link
Contributor

@kjnilsson kjnilsson commented Mar 24, 2025

As this functionality is covered by the rabbit_queue_type:is_enabled/1 API.

Remove rabbit_queue_type:to_binary/1
As it is covered by rabbit_queue_type:short_alias_of/1

As this functionality is covered by the rabbit_queue_type:is_enabled/1
API.
@ikavgo
Copy link
Contributor

ikavgo commented Mar 24, 2025

Do I get it right that ff names change? for example for QQs before - quorum_queue and after is rabbit_quorum_queue? Or those completely irrelevant now?

@kjnilsson kjnilsson changed the title Remove rabbit_queue_type:feature_flag_name/1 Remove redundant rabbit_queue_type APIs Mar 24, 2025
@kjnilsson kjnilsson marked this pull request as draft March 24, 2025 14:59
@kjnilsson kjnilsson force-pushed the remove-redundant-queue-type-function branch from ea1f6d0 to 4cef9e3 Compare March 24, 2025 15:04
As it is covered by rabbit_queue_type:short_alias_of/1
@kjnilsson kjnilsson force-pushed the remove-redundant-queue-type-function branch from 4cef9e3 to 0410b7e Compare March 24, 2025 16:28
@kjnilsson kjnilsson marked this pull request as ready for review March 25, 2025 09:50
@michaelklishin michaelklishin added this to the 4.1.0 milestone Mar 25, 2025
@michaelklishin michaelklishin merged commit 3a30917 into main Mar 25, 2025
273 checks passed
@michaelklishin michaelklishin deleted the remove-redundant-queue-type-function branch March 25, 2025 21:43
michaelklishin added a commit that referenced this pull request Mar 26, 2025
Remove redundant rabbit_queue_type APIs (backport #13603)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants