Skip to content

Fix the errors logged by Cowboy caused by double reply in a few endpoints #13612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 25, 2025
Merged

Fix the errors logged by Cowboy caused by double reply in a few endpoints #13612

merged 1 commit into from
Mar 25, 2025

Conversation

lhoguin
Copy link
Contributor

@lhoguin lhoguin commented Mar 25, 2025

Issue introduced in 383ddb1.

Types of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause an observable behavior change in existing systems)
  • Documentation improvements (corrections, new content, etc)
  • Cosmetic change (whitespace, formatting, etc)
  • Build system and/or CI

Checklist

Put an x in the boxes that apply.
You can also fill these out after creating the PR.
If you're unsure about any of them, don't hesitate to ask on the mailing list.
We're here to help!
This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING.md document
  • I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
  • I have added tests that prove my fix is effective or that my feature works
  • All tests pass locally with my changes
  • If relevant, I have added necessary documentation to https://github.com/rabbitmq/rabbitmq-website
  • If relevant, I have added this change to the first version(s) in release-notes that I expect to introduce it

Further Comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution
you did and what alternatives you considered, etc.

@lhoguin lhoguin marked this pull request as ready for review March 25, 2025 13:29
@lhoguin
Copy link
Contributor Author

lhoguin commented Mar 25, 2025

Please do "squash and merge" when merging after review.

@lukebakken lukebakken self-assigned this Mar 25, 2025
@lukebakken lukebakken force-pushed the loic-fix-404-crashes branch from a6d716d to ab09567 Compare March 25, 2025 15:01
lukebakken
lukebakken approved these changes Mar 25, 2025
View reviewed changes
Copy link
Collaborator

@lukebakken lukebakken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with script provided by issue reporter 👍

@michaelklishin michaelklishin changed the title Fix Cowboy crashes caused by double reply Fix the errors logged by Cowboy caused by double reply in a few endpoints Mar 25, 2025
@michaelklishin michaelklishin added this to the 4.1.0 milestone Mar 25, 2025
@michaelklishin michaelklishin merged commit 0a7c86b into main Mar 25, 2025
271 checks passed
@michaelklishin michaelklishin deleted the loic-fix-404-crashes branch March 25, 2025 21:12
mergify bot pushed a commit that referenced this pull request Mar 25, 2025
@lhoguin @mergify
Fix the exception logged by Cowboy caused by double reply (#13612)
dfe484b 
Issue introduced in 383ddb1.

Authored-by: @lhoguin.
(cherry picked from commit 0a7c86b)
@mergify mergify bot mentioned this pull request Mar 25, 2025
Merged
12 tasks
michaelklishin added a commit that referenced this pull request Mar 25, 2025
@michaelklishin
Merge pull request #13615 from rabbitmq/mergify/bp/v4.1.x/pr-13612
a498fb7 
Fix the errors logged by Cowboy caused by double reply in a few endpoints (backport #13612)
mergify bot pushed a commit that referenced this pull request Mar 25, 2025
@lhoguin @mergify
Fix the exception logged by Cowboy caused by double reply (#13612)
0482f06 
Issue introduced in 383ddb1.

Authored-by: @lhoguin.
(cherry picked from commit 0a7c86b)
(cherry picked from commit dfe484b)

# Conflicts:
#	deps/rabbitmq_management/src/rabbit_mgmt_wm_exchange_publish.erl
#	deps/rabbitmq_management/src/rabbit_mgmt_wm_queue_actions.erl
#	deps/rabbitmq_management/src/rabbit_mgmt_wm_queue_get.erl
@mergify mergify bot mentioned this pull request Mar 25, 2025
Merged
12 tasks
michaelklishin added a commit that referenced this pull request Mar 26, 2025
@michaelklishin
Resolve a conflict #13615 #13612 #13619
fa5737c
michaelklishin added a commit that referenced this pull request Mar 26, 2025
@michaelklishin
Merge pull request #13619 from rabbitmq/mergify/bp/v4.0.x/pr-13615
f820888 
Fix the errors logged by Cowboy caused by double reply in a few endpoints (backport #13612) (backport #13615)
mkuratczyk pushed a commit that referenced this pull request Mar 26, 2025
@lhoguin @mkuratczyk
Fix the exception logged by Cowboy caused by double reply (#13612)
5a848cd 
Issue introduced in 383ddb1.

Authored-by: @lhoguin.
ikavgo pushed a commit that referenced this pull request May 5, 2025
@lhoguin @ikavgo
Fix the exception logged by Cowboy caused by double reply (#13612)
8a1c1ae 
Issue introduced in 383ddb1.

Authored-by: @lhoguin.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukebakken lukebakken lukebakken approved these changes

@michaelklishin michaelklishin Awaiting requested review from michaelklishin

Assignees

@lukebakken lukebakken

Labels
backport-v4.1.x
Projects
None yet
Milestone
4.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@lhoguin @lukebakken @michaelklishin