Skip to content

Use relative path for the path linked to the cookie (backport #13664) (backport #13666) #13668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 1, 2025

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Apr 1, 2025

Proposed Changes

This PR fixes a regression added to the management ui's oauth authentication. This regression occurs only when the ui is mounted on a custom path.

Use relative path for the path linked to the cookie used by manegement ui's oauth logic to store the token until it is moved onto the local storage.

Types of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause an observable behavior change in existing systems)
  • Documentation improvements (corrections, new content, etc)
  • Cosmetic change (whitespace, formatting, etc)
  • Build system and/or CI

This is an automatic backport of pull request #13664 done by [Mergify](https://mergify.com).
This is an automatic backport of pull request #13666 done by [Mergify](https://mergify.com).

used by mangement ui oauth logic to store the
token until it is moved onto the local storage

(cherry picked from commit 8dfcfa6)
(cherry picked from commit 40d180b)
(cherry picked from commit 03fae66)
(cherry picked from commit 63d95f8)

# Conflicts:
#	selenium/short-suite-management-ui
@mergify mergify bot added the conflicts label Apr 1, 2025
Copy link
Author

mergify bot commented Apr 1, 2025

Cherry-pick of 63d95f8 has failed:

On branch mergify/bp/v4.0.x/pr-13666
Your branch is ahead of 'origin/v4.0.x' by 1 commit.
  (use "git push" to publish your local commits)

You are currently cherry-picking commit 63d95f89f.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   selenium/short-suite-management-ui

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@michaelklishin michaelklishin added this to the 4.0.8 milestone Apr 1, 2025
@michaelklishin michaelklishin merged commit 100c16a into v4.0.x Apr 1, 2025
1 check passed
@michaelklishin michaelklishin deleted the mergify/bp/v4.0.x/pr-13666 branch April 1, 2025 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants