Skip to content

Add health checks for testing readiness to serve clients #13879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 9, 2025

Conversation

the-mikedavis
Copy link
Collaborator

@the-mikedavis the-mikedavis commented May 9, 2025

Proposed Changes

This covers the remaining two checks in #13782. One tests the connection limit for the node and the other is a kind of composite check that combines #13872 and checks whether listeners are available for AMQP/AMQPS.

Closes #13782

Types of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause an observable behavior change in existing systems)
  • Documentation improvements (corrections, new content, etc)
  • Cosmetic change (whitespace, formatting, etc)
  • Build system and/or CI

Checklist

Put an x in the boxes that apply.
You can also fill these out after creating the PR.
If you're unsure about any of them, don't hesitate to ask on the mailing list.
We're here to help!
This is simply a reminder of what we are going to look for before merging your code.

Further Comments

These checks only apply to AMQP + AMQPS because that's what the connection_max currently applies to. In the future these checks could be updated to also cover other protocols. If desired I could pick up #9876. We can use ranch:info/1 as Loic suggested in #7593 to efficiently count connections per protocol.

@the-mikedavis the-mikedavis self-assigned this May 9, 2025
@the-mikedavis the-mikedavis changed the title Add health checks for testing readiness to serve cliens Add health checks for testing readiness to serve clients May 9, 2025
@michaelklishin michaelklishin modified the milestones: 4.1.1, 4.2.0 May 9, 2025
@michaelklishin michaelklishin merged commit 44cebf2 into main May 9, 2025
271 checks passed
@michaelklishin michaelklishin deleted the md/health-check-ready-to-serve branch May 9, 2025 18:46
michaelklishin added a commit that referenced this pull request May 9, 2025
Add health checks for testing readiness to serve clients (backport #13879)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A health check to verify if the node is ready to take on new connections
2 participants