Skip to content

Do not render Delete button for internal queues #13909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 19, 2025

Conversation

ikavgo
Copy link
Contributor

@ikavgo ikavgo commented May 18, 2025

Proposed Changes

Protected queues - do not render Delete button for internal queues

Types of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause an observable behavior change in existing systems)
  • Documentation improvements (corrections, new content, etc)
  • Cosmetic change (whitespace, formatting, etc)
  • Build system and/or CI

Checklist

Put an x in the boxes that apply.
You can also fill these out after creating the PR.
If you're unsure about any of them, don't hesitate to ask on the mailing list.
We're here to help!
This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING.md document
  • I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
  • I have added tests that prove my fix is effective or that my feature works
  • All tests pass locally with my changes
  • If relevant, I have added necessary documentation to https://github.com/rabbitmq/rabbitmq-website
  • If relevant, I have added this change to the first version(s) in release-notes that I expect to introduce it

@ikavgo ikavgo requested a review from michaelklishin May 18, 2025 21:26
@ikavgo
Copy link
Contributor Author

ikavgo commented May 18, 2025

This is a follow-up to #13525 I forgot to upstream.

@ikavgo ikavgo force-pushed the ik-queue-protection-mgmt branch from 40a53f8 to 5fd3bdd Compare May 18, 2025 21:51
@michaelklishin michaelklishin added this to the 4.2.0 milestone May 19, 2025
@michaelklishin michaelklishin changed the title Protected queues - do not render Delete button for internal queues Do not render Delete button for internal queues May 19, 2025
@michaelklishin michaelklishin merged commit c29fc82 into main May 19, 2025
271 checks passed
@michaelklishin michaelklishin deleted the ik-queue-protection-mgmt branch May 19, 2025 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants