RABBITMQ_NAME_TYPE should be correctly set in Windows batch files #1514
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukebakken
changed the title
…PE is used correctly in Windows batch files
lukebakken
force-pushed
the
rabbitmq-server-1508
branch
from
4713344 to
3c82673
Compare
lukebakken
changed the title
lukebakken
changed the title
…pt reads from the env
lukebakken
changed the title
lukebakken
requested review from
michaelklishin
and removed request for
michaelklishin
michaelklishin
approved these changes
Feb 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove unused
-nodenameargument toerl, ensure thatRABBITMQ_NAME_TYPEis used correctly in Windows batch filesFixes #1508
@michaelklishin - I confirmed that it's OK to remove
-nodenamesince therabbitmq-clicommands will get the value from theRABBITMQ_NODENAMEenv variable.