Configurable max procs max atoms master #1529
Conversation
* Handle more responses * Don't emit confusing suggestions that rabbit (or plugin) setting should be set in the advanced.config file as that won't change a thing (but it will for kernel)
…ime-in-new-config-format Support kernel.net_ticktime in Cuttlefish configuration
This property is essential for nodes that need to handle many connections / channels / queues. Related to #1513
This was the only property in SERVER_ERL_ARGS that was not configurable. Even though it's unlikely that this will need to be increased above the existing 5 million default, we are consistent in allowing all properties in SERVER_ERL_ARGS to be cofigured.
This was the only property in SERVER_ERL_ARGS that was not configurable. Even though it's unlikely that this will need to be increased above the existing 5 million default, we are consistent in allowing all properties in SERVER_ERL_ARGS to be cofigured. (cherry picked from commit b1e163f)
scripts/rabbitmq-env
Outdated
| [ "x" = "x$RABBITMQ_MAX_NUMBER_OF_PROCESSES" ] && RABBITMQ_MAX_NUMBER_OF_PROCESSES=="${DEFAULT_MAX_NUMBER_OF_PROCESSES}" | ||
|
|
||
| DEFAULT_MAX_NUMBER_OF_ATOMS=5000000 | ||
| [ "x" = "x$RABBITMQ_MAX_NUMBER_OF_ATOMS" ] && RABBITMQ_MAX_NUMBER_OF_ATOMS=="${DEFAULT_MAX_NUMBER_OF_ATOMS}" |
There was a problem hiding this comment.
== seems to be bash-specific and is not available in zsh.
There was a problem hiding this comment.
I totally missed that, assignment vs comparison. Fixing it now and figuring out why make bats didn't catch it
There was a problem hiding this comment.
ShellCheck catches it, too:
In scripts/rabbitmq-env line 91:
[ "x" = "x$RABBITMQ_MAX_NUMBER_OF_PROCESSES" ] && RABBITMQ_MAX_NUMBER_OF_PROCESSES=="${DEFAULT_MAX_NUMBER_OF_PROCESSES}"
^-- SC1097: Unexpected ==. For assignment, use =. For comparison, use [/[[.
In scripts/rabbitmq-env line 94:
[ "x" = "x$RABBITMQ_MAX_NUMBER_OF_ATOMS" ] && RABBITMQ_MAX_NUMBER_OF_ATOMS=="${DEFAULT_MAX_NUMBER_OF_ATOMS}"
^-- SC1097: Unexpected ==. For assignment, use =. For comparison, use [/[[.
|
Another thing I've noticed, which doesn't have to be addressed in this PR, is that in |
|
@michaelklishin that's correct and is also something I just noticed. Addressing it as well. |
… with RABBITMQ_, adjust Unix and Windows files accordingly
…-procs-max-atoms-master
…-procs-max-atoms-master
|
@lukebakken this comment applies here as well. Pretty sure the original env vars which started with |
|
The docs suggest otherwise. |
|
Merging per verbal approval from @dumbbell. |
Proposed Changes
Same as #1528 by @gerhard but against
master.