-
Notifications
You must be signed in to change notification settings - Fork 3.9k
Config files check #1671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Config files check #1671
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
005d3f2
Refactor config file discovery. Make advanced config load if no old f…
hairyhum 67620ef
Expect extensions in config filename arguments
hairyhum d296e80
Simple validation for config file content and extension.
hairyhum b8606a2
Fix function removing extension.
hairyhum 38dc94b
Better warning and error messages in scripts.
hairyhum 80b22cd
Do not show non-existent .conf file as a configuration file in logs
hairyhum f1db86a
Do not add ./ to NOEX files if the file is in the current dir
hairyhum bcdd788
Move file with no extension variable assignment before it's used
hairyhum 61f7e9c
Improve the error message when a config file is not in the correct fo…
hairyhum 56a372c
Use file:consult to check if .conf is of the old format. Add more err…
hairyhum 220ec77
Batch file syntax errors. Config check error format
hairyhum 721fef6
Add extension to default advanced config file name on windows
hairyhum 34bba9b
Remove typo
lukebakken File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think about combining the configuration setup code into its own
.bat
file to be shared betweenrabbitmq-server.bat
andrabbitmq-service.bat
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We do have
rabbitmq-env.bat
. Do you think it can be moved there?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's wait for future powershell work