Add detail for channel_max 0 value #1673
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is not immediately obvious that a 0 value for channel_max means infinite or "no limit". This change will result in the following message being logged: "negotiated channel_max = 0 (no limit) is higher than the maximum allowed value (2047)"
lukebakken
commented
Aug 15, 2018
| @@ -446,7 +453,7 @@ log_connection_exception_with_severity(Severity, Fmt, Args) -> | |||
| debug -> rabbit_log_connection:debug(Fmt, Args); | |||
| info -> rabbit_log_connection:info(Fmt, Args); | |||
| warning -> rabbit_log_connection:warning(Fmt, Args); | |||
| error -> rabbit_log_connection:warning(Fmt, Args) | |||
There was a problem hiding this comment.
Good catch @michaelklishin
michaelklishin
approved these changes
Aug 15, 2018
lukebakken
added a commit
that referenced
this pull request
Aug 15, 2018
Add detail for channel_max 0 value (cherry picked from commit c7dea58)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is not immediately obvious that a 0 value for channel_max means infinite or "no limit". This change will result in the following message being logged:
"negotiated channel_max = 0 (no limit) is higher than the maximum allowed value (2047)"