Skip to content

Increase performance of auto_delete queues deletion on channel down #1675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 17, 2018

Conversation

dcorbacho
Copy link
Contributor

@dcorbacho dcorbacho commented Aug 16, 2018

Re-introduce previous delete guard for auto_delete queues.
Undo performance enhancement introduced by #1513 for this use case.
All other bulk deletions remain the same.

Types of Changes

  • Bugfix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (correction or otherwise)
  • Cosmetics (whitespace, appearance)

Checklist

  • I have read the CONTRIBUTING.md document
  • I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
  • All tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in related repositories

Re-introduce previous delete guard for auto_delete queues.
Undo performance enhancement introduced by #1513 for this use case.
All other bulk deletions remain the same.

[#159483364]
Copy link
Contributor

@acogoluegnes acogoluegnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't reproduce the issue whereby client topology recovery kicks in when auto-deletion of queues isn't finished, resulting in errors during binding and consumer recovery because queues have been deleted meanwhile. Looks good to me, well done @dcorbacho!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants