Don't error when a queue that's being deleted has no bindings left to remove on transaction retries #1689
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It can happen due to retries of (currently not guaranteed to be idempotent,
which is a separate issue in the works) binding removal. Since both
the queue and its bindings are undergoing removal, don't fail when
there's nothing left to be removed for the current transaction [attempt].
This avoids obscure and non-actionable errors in the log ({error, not_found}).
Note that the error is also not handled by the callers and ignoring them
is the only reasonable course of action that I can think of.
Per discussion with @dumbbell @dcorbacho @hairyhum.
michaelklishin
changed the title
michaelklishin
changed the title
|
Merging per discussion with @dumbbell. |
michaelklishin
added a commit
that referenced
this pull request
Mar 13, 2019
Since it makes direct Erlang client connections possible. References #1689.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
It can happen due to retries of (currently not guaranteed to be idempotent,
which is a separate issue in the works) binding removal. Since both
the queue and its bindings are undergoing removal, don't fail when
there's nothing left to be removed for the current transaction [attempt].
This avoids obscure and non-actionable errors in the log ({error, not_found}).
Note that the error is also not handled by the callers and ignoring them
is the only reasonable course of action that I can think of.
Types of Changes
Checklist
CONTRIBUTING.mddocumentFurther Comments
Per discussion with @dumbbell @dcorbacho @hairyhum.