Skip to content

Fix a potential badmatch error #1694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 5, 2018

Conversation

lukebakken
Copy link
Collaborator

@lukebakken lukebakken commented Sep 5, 2018

[159000315]

You can get badmatch if you run the broker with arguments like this:

make RABBITMQ_ALLOW_INPUT=true RABBITMQ_ADVANCED_CONFIG_FILE=/Users/lbakken/issues/pt/159000315-conf-format-check/test3/rabbitmq.conf RABBITMQ_CONFIG_FILE=/Users/lbakken/issues/pt/159000315-conf-format-check/test3/advanced.config run-broker

With this change, the following message is printed:

ERROR: RABBITMQ_ADVANCED_CONFIG_FILE: Expected extension .config, got extension .conf for file /Users/lbakken/issues/pt/159000315-conf-format-check/test3/rabbitmq.conf

You can get `badmatch` if you run the broker with arguments like this:

```
make RABBITMQ_ALLOW_INPUT=true RABBITMQ_ADVANCED_CONFIG_FILE=/Users/lbakken/issues/pt/159000315-conf-format-check/test3/rabbitmq.conf RABBITMQ_CONFIG_FILE=/Users/lbakken/issues/pt/159000315-conf-format-check/test3/advanced.config run-broke
```

With this change, the following message is printed:

```
ERROR: RABBITMQ_ADVANCED_CONFIG_FILE: Expected extension .config, got extension .conf for file /Users/lbakken/issues/pt/159000315-conf-format-check/test3/rabbitmq.conf
```
@lukebakken lukebakken added this to the 3.7.8 milestone Sep 5, 2018
@lukebakken lukebakken self-assigned this Sep 5, 2018
@michaelklishin michaelklishin merged commit 7ef3b27 into master Sep 5, 2018
@michaelklishin michaelklishin deleted the lrb-fix-badmatch-file-extension branch September 5, 2018 15:20
lukebakken pushed a commit that referenced this pull request Sep 5, 2018
Fix a potential badmatch error

(cherry picked from commit 7ef3b27)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants