Skip to content

Make rabbit_vhost:add/2 idempotent #1714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 28, 2018
Merged

Make rabbit_vhost:add/2 idempotent #1714

merged 2 commits into from
Sep 28, 2018

Conversation

michaelklishin
Copy link
Collaborator

@michaelklishin michaelklishin commented Sep 27, 2018

Proposed Changes

This makes rabbit_vhost:add/2 idempotent. Returning an error when an existing vhost is [re-]created
is not productive and worsens CLI and automation tool experience.

Types of Changes

Technically it's a breaking change but we don't expect it to break a system that can handle
both success and error responses in a reasonable way.

  • Bug fix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (correction or otherwise)
  • Cosmetics (whitespace, appearance)

Checklist

  • I have read the CONTRIBUTING.md document
  • I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
  • All tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in related repositories

Further Comments

Part of rabbitmq/rabbitmq-cli#260.

[#160792770]

@michaelklishin michaelklishin merged commit 8345623 into master Sep 28, 2018
@michaelklishin michaelklishin deleted the rabbitmq-cli-260 branch September 28, 2018 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants