Make default exchange bindings implicit #1721
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems like |
Routing from default exchange is performed without querying bindings and they cannot be unbound and only show in `rabbitmqctl list_bindings`. There is no point in keeping them and they are slowing down cleanup.
The min-masters locator was originally designed to count bindings, but this was confusing for people wanting to distribute queues rather than routes to queues. This was changed in 1d413ea to count only queues which have at least one binding. But queues always have bindings (default) and hence it's equivalent to listing queues. Since default bindings are removed the location was broken. This commit changes the location to actually list queues rather than bindings.
hairyhum
force-pushed
the
remove-default-bindings
branch
from
d5b490f to
10013f5
Compare
Default bindings are not represented in the mnesia database but still expected in the management UI and the rabbitmqctl command.
hairyhum
changed the title
michaelklishin
requested changes
Jan 1, 2019
|
So far I see two types of failures:
|
|
Fake bindings should have fixed that. I'll take a look. |
rabbit_binding:exists checks bindings table. Since default bindings are not in that table anymore, it should check for queue existence.
|
Fixed |
michaelklishin
approved these changes
Jan 3, 2019
This avoids duplicates after an existing installation is upgraded. References #1721.
michaelklishin
approved these changes
Jan 3, 2019
Merged
michaelklishin
changed the title
michaelklishin
added a commit
to rabbitmq/rabbitmq-event-exchange
that referenced
this pull request
Jan 10, 2019
hairyhum
added a commit
that referenced
this pull request
Jan 15, 2019
Versions before 3.8 create default bindings for queues in the database. Since #1721 they are replaced with placeholders only for list operations. We need to cleanup the bindings to improve binding performance with older queues. [#163224049]
hairyhum
added a commit
that referenced
this pull request
Jan 15, 2019
Backport of c7d107d 10013f5 e01dc98 7ba04a6 In 3.8 queues will not create default bindings. Because default bindings are only used in list function, it should be safe to run in a mixed mode with 3.8. List functions should show implicit bindings for queues created in 3.8. Min master locator logic is simplified and with or without default bindings will have the same behaviour as before. Follow-up to #1721
michaelklishin
added a commit
that referenced
this pull request
Feb 16, 2019
…_destination/1` Follow-up to #1721. Even though the default exchange bindings are deleted at schema migration time, this filtering improves backwards compatibility for mixed version clusters.
|
This was backported to |
kjnilsson
pushed a commit
that referenced
this pull request
Feb 20, 2019
…_destination/1` Follow-up to #1721. Even though the default exchange bindings are deleted at schema migration time, this filtering improves backwards compatibility for mixed version clusters.
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split from #1715
Default bindings slow down queue creation and deletion and are not used in the actual routing logic. They are returned in some HTTP API endpoints though, therefore to merge this PR there should be some changes done in the management plugin.
There is no information in bindings which cannot be extracted from queues, which makes it possible to fake results for HTTP API. The question is should we do that or make the bindings result empty if there are no explicit bindings?
The definitions result does not contain default bindings BTW.