Skip to content

Report message bytes in quorum queue stats #1796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 14, 2018
Merged

Conversation

dcorbacho
Copy link
Contributor

rabbit_fifo keeps track of message bytes ready and unacknowledged and publishes them with the queue stats. It uses the new message_size_handler to calculate message size.

[#161505138]

Types of Changes

  • Bugfix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (correction or otherwise)
  • Cosmetics (whitespace, appearance)

Checklist

  • I have read the CONTRIBUTING.md document
  • I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
  • All tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in related repositories

@dcorbacho
Copy link
Contributor Author

@kjnilsson @michaelklishin Message size is recalculated every time the messages is unack or returned to the queue. Should we add it to the message properties we handle in rabbit_fifo? Any possible downside to this?

@kjnilsson kjnilsson force-pushed the report-message-bytes branch from d066e86 to 3676541 Compare December 14, 2018 14:16
@kjnilsson kjnilsson merged commit bc662bc into master Dec 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants