Bugfixes #1803
Merged
Bugfixes #1803
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes bug that muddled up the checkout order when a consumer is cancelled with more than 32 messages checked out. Dialyzer fixes. [#162698673]
When a consumer node is disconnected the quorum queue will return all outstanding messages for the consumer to the queue as it cannot know if the consumer will ever come back or not and cannot leave things checked out forever. If the consumer node then reconnectes and the consumer channel is still alive it may try to query for missing deliveries and this previously crashed if the messages had been returned to the main queue. This fix makes the query safer as well as handling missing messages better.
michaelklishin
approved these changes
Dec 18, 2018
dcorbacho
approved these changes
Dec 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bugfixes of bugs discovered by @Vanlightly
rabbit_quorum_queue:update_metrics/2 used calls to remote processes.
To avoid this blocking the ra server in a partition we now spawn a new
process for this.
Due to a refactoring miss commands over the soft limit where never
formatted successfully in rabbit_fifo_client and thus never got processed.
return messages in order …
Fixes bug that muddled up the checkout order when a consumer is
cancelled with more than 32 messages checked out.
Fix bug that would crash the ra leader when a disconnected consumer was reconnected.