Skip to content

Do not include x-delivery-count header on first delivery. #1807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 19, 2018
Merged

Do not include x-delivery-count header on first delivery. #1807

merged 1 commit into from
Dec 19, 2018

Conversation

kjnilsson
Copy link
Contributor

[#162755631]

@michaelklishin michaelklishin merged commit 794ef8d into master Dec 19, 2018
@michaelklishin michaelklishin deleted the redlivery-count-fix branch December 19, 2018 19:35
@michaelklishin michaelklishin mentioned this pull request Dec 24, 2018
Closed
@BhupenPal
Copy link

@kjnilsson @michaelklishin Why this change has been done?

@michaelklishin
Copy link
Collaborator

@BhupenPal I don't think anyone remembers the exact reason but x-delivery-count only makes sense for redeliveries. For redeliveries, it is included.

We won't discuss this on a five year old PR, if you have something to suggest, please use GitHub Discussions.

@BhupenPal
Copy link

@michaelklishin Yes, I understand. Thanks for replying, I have a contrary viewpoint but I guess it's a discussion for some other day

@kjnilsson
Copy link
Contributor Author

@michaelklishin Yes, I understand. Thanks for replying, I have a contrary viewpoint but I guess it's a discussion for some other day

There is no need to introduce unnecessary overhead for the most common delivery (i.e the first delivery). that is why it isn't included and almost certainly never will be. Cheers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelklishin michaelklishin michaelklishin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kjnilsson @BhupenPal @michaelklishin