Check exclusive owner before durable argument #1888
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukebakken
changed the title
lukebakken
force-pushed
the
rabbitmq-server-1887
branch
from
8da757c to
4f853ad
Compare
lukebakken
changed the title
See #1887 for context. When an exclusive queue is redeclared with the exclusive property set to `false`, the code considers it to be an ownership check. This is a leaked implementation detail that's been around for years, so changing it might do more harm than good. What we can do is provide a bit more information about when the check might fail in the message.
michaelklishin
approved these changes
Feb 18, 2019
lukebakken
pushed a commit
that referenced
this pull request
Feb 18, 2019
Check exclusive owner before durable argument (cherry picked from commit d680193)
|
Backported to |
michaelklishin
added a commit
that referenced
this pull request
Feb 18, 2019
This reverts commit 70ced1b. This PR depends on a module only available in 3.8.
lukebakken
pushed a commit
that referenced
this pull request
Feb 18, 2019
Check exclusive owner before durable argument (cherry picked from commit d680193)
michaelklishin
added a commit
to ruby-amqp/bunny
that referenced
this pull request
Feb 19, 2019
This was referenced Feb 20, 2019
This was referenced Feb 27, 2019
michaelklishin
added a commit
to rabbitmq/rabbitmq-objc-client
that referenced
this pull request
Mar 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1887
See #1887 for code to reproduce the issue.
With this PR, the error makes more sense: