Ensure resources are cleaned up when connection socket is closed before Ranch handshake completes #1902
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelklishin
changed the title
lukebakken
force-pushed
the
rabbitmq-server-1901
branch
from
d26a2af to
85da671
Compare
lukebakken
commented
Feb 27, 2019
| rabbit_log:error(Msg, [Error]), | ||
| % The following call will clean up resources then exit | ||
| _ = ranch:handshake(Ref), | ||
| exit({shutdown, failed_to_recv_proxy_header}). |
There was a problem hiding this comment.
@michaelklishin I don't think that this line will be reached in a real {error, closed} situation as ranch:handshake should exit here. But, there's no harm in leaving this exit call in.
michaelklishin
approved these changes
Feb 27, 2019
lukebakken
pushed a commit
that referenced
this pull request
Feb 27, 2019
Ensure resources are cleaned up when connection socket is closed before Ranch handshake completes (cherry picked from commit 08bce61)
|
Backported to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1901
I'm not 100% sure this is the right way to clean up when
ranch:recv_proxy_headerbut I think this makes sense.Also see: https://groups.google.com/d/topic/rabbitmq-users/3HAMNDucUPI/discussion