Skip to content

Speedup execution of bootsteps #2246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 15, 2020
Merged

Speedup execution of bootsteps #2246

merged 1 commit into from
Feb 15, 2020

Conversation

Ayanda-D
Copy link
Contributor

Proposed Changes

This improves speed of bootstep execution by factor of 2N, where N is
number of attributes per step, matching the passed AttributeName.
Overall time complexity remains O(N), dropping constant from O(2N),
but we don't expect N to be significantly large enough to neglect the
constant for modules with multiple attributes.

Types of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause an observable behavior change in existing systems)
  • Documentation improvements (corrections, new content, etc)
  • Cosmetic change (whitespace, formatting, etc)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating
the PR. If you're unsure about any of them, don't hesitate to ask on the
mailing list. We're here to help! This is simply a reminder of what we are
going to look for before merging your code.

  • I have read the CONTRIBUTING.md document
  • I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
  • All tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in related repositories

Further Comments

If this is a relatively large or complex change, kick off the discussion by
explaining why you chose the solution you did and what alternatives you
considered, etc.

filtering and grouping of MFA specifications. This
improves speed of execution by factor of 2N, where
N is number of attributes per step, matching the
passed `AttributeName`. Dropping constants, overall
time complexity remains O(N), but cant be neglected
for modules with multiple bootstep attributes.
@michaelklishin michaelklishin merged commit 3aa744f into rabbitmq:master Feb 15, 2020
@michaelklishin
Copy link
Collaborator

Thank you!

michaelklishin added a commit that referenced this pull request Feb 15, 2020
Speedup execution of bootsteps

(cherry picked from commit 3aa744f)
michaelklishin added a commit that referenced this pull request Feb 15, 2020
Speedup execution of bootsteps

(cherry picked from commit 3aa744f)
@michaelklishin
Copy link
Collaborator

Backported to v3.8.x and v3.7.x.

@Ayanda-D Ayanda-D deleted the speedup-bootsteps branch October 16, 2020 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants