Skip to content

Make Web-MQTT obtain/release a FD via file_handle_cache #3076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 2, 2021

Conversation

lhoguin
Copy link
Contributor

@lhoguin lhoguin commented Jun 2, 2021

I have noticed that Web-MQTT does not keep track of its own FD usage,
meaning that when a Websocket connection is open, it is invisible. On
the other hand Web-STOMP connections are visible when calling
file_handle_cache:info() and counted when checking limits.

I have therefore applied a small patch to Web-MQTT to make it
behave just like Web-STOMP. I have also added a missing link
in a Web-MQTT example.

Types of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause an observable behavior change in existing systems)
  • Documentation improvements (corrections, new content, etc)
  • Cosmetic change (whitespace, formatting, etc)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating
the PR. If you're unsure about any of them, don't hesitate to ask on the
mailing list. We're here to help! This is simply a reminder of what we are
going to look for before merging your code.

  • I have read the CONTRIBUTING.md document
  • I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
  • All tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in related repositories

@michaelklishin michaelklishin merged commit 2be1f16 into master Jun 2, 2021
@michaelklishin michaelklishin deleted the web-mqtt-fd-limit branch June 2, 2021 09:39
michaelklishin added a commit that referenced this pull request Jun 2, 2021
Make Web-MQTT obtain/release a FD via file_handle_cache

(cherry picked from commit 2be1f16)
@michaelklishin
Copy link
Collaborator

Backported to v3.8.x.

@michaelklishin michaelklishin added this to the 3.8.17 milestone Jun 2, 2021
@michaelklishin
Copy link
Collaborator

Disregard my earlier comment, I see that Web STOMP is not affected 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants