Skip to content

When reacting to a forced event refresh command, emit consumer creation events for all consumers #3078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 2, 2021
Merged

When reacting to a forced event refresh command, emit consumer creation events for all consumers #3078

merged 2 commits into from
Jun 2, 2021

Conversation

michaelklishin
Copy link
Collaborator

Proposed Changes

Emit consumer creation events for all consumers
when force refreshing events. We do that when consumers are registered
online. Inactive consumers in case of SAC queues are still present
and their presence should be broadcast as an internal event.

This also simplifies the code updated for #3072.

Per discussion with @pjk25.

Types of Changes

  • Bug fix (non-breaking change which fixes issue Restart node causes queues with a SAC to run into a badmatch #3072)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause an observable behavior change in existing systems)
  • Documentation improvements (corrections, new content, etc)
  • Cosmetic change (whitespace, formatting, etc)

Checklist

  • I have read the CONTRIBUTING.md document
  • I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
  • All tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in related repositories

Further Comments

Closes #3072

@michaelklishin
Be more defensive when emitting consumer events for a queue with SAC
8f234dd 
A queue that had a SAC but currently has none (e.g. because client
connection failed) should not fail with a badmatch.

Clearing the holder field will be investigated separately.

Closes #3072
@michaelklishin
Emit consumer creation events for all consumers
eb96ac9 
when force refreshing events. We do that when consumers are registered
online. Inactive consumers in case of SAC queues are still present
and their presence should be broadcast as an internal event.

This also simplifies the code updated for #3072.

Per discussion with @pjk25.
@michaelklishin michaelklishin requested a review from HoloRin June 2, 2021 12:36
@michaelklishin michaelklishin mentioned this pull request Jun 2, 2021
Closed
@HoloRin HoloRin merged commit 4b95614 into master Jun 2, 2021
@michaelklishin michaelklishin deleted the rabbitmq-server-3072 branch June 2, 2021 14:43
michaelklishin pushed a commit that referenced this pull request Jun 2, 2021
@HoloRin @michaelklishin
Merge pull request #3078 from rabbitmq/rabbitmq-server-3072
b3f57e3 
When reacting to a forced event refresh command, emit consumer creation events for all consumers

(cherry picked from commit 4b95614)
@michaelklishin
Copy link
Collaborator Author

Backported to v3.8.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HoloRin HoloRin HoloRin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Restart node causes queues with a SAC to run into a badmatch
2 participants
@michaelklishin @HoloRin