-
Notifications
You must be signed in to change notification settings - Fork 3.9k
Extract TLS informations that are delivered in PROXY protocol frame #3175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract TLS informations that are delivered in PROXY protocol frame #3175
Conversation
@prefiks any reason why MQTT, STOMP and possibly their WebSocket counterparts are not updated in this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have done a preliminary review of the code and it looks fine.
I have not tried the code yet.
I think Ranch should have a function that converts from ProxyInfo to what ssl:connection_information/1
returns. I have opened a ticket there. This however in no way invalidates this PR, this is more of a good idea to add in a future release of Ranch.
I think it works MQTT/STAMP, i believe those end calling amqp_direct_connection:socket_adapter_info/2, which in turn do use that newly added code. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Extract TLS informations that are delivered in PROXY protocol frame (cherry picked from commit 29bb9c5)
Backported to |
Extract TLS informations that are delivered in PROXY protocol frame (cherry picked from commit 29bb9c5)
Backported to |
Proposed Changes
This adds extractor for TLS details that are provided in PROXY protocol payload. This makes connections that do use HAProxy to handle TLS (and have PROXY protocol enabled), show that they are encrypted and have data about protocol cipher that this connection used
displayed in management ui.
Types of Changes
What types of changes does your code introduce to this project?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creatingthe PR. If you're unsure about any of them, don't hesitate to ask on the
mailing list. We're here to help! This is simply a reminder of what we are
going to look for before merging your code.
CONTRIBUTING.md
documentFurther Comments
This extends already existing PROXY support with handling of TLS information that can be passed in it. This doesn't add passing information about client certificates, data that is provided that way, doesn't looks like is compatible with what rabbit is expecting, there is just not enough information in that.
This was sponsored by 84codes/CloudAMQP.